VERIFIY therepanic gh 1241 #1263
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The consumer factories now respect the configured PulsarTopicBuilder and will fully-qualify the `deadLetterTopic` and `retryLetterTopic` on the `DeadLetterPolicy`. This allows users to not have to fully-qualify these topic names. Resolves spring-projects#1241 Signed-off-by: Andrey Litvitski <[email protected]>
Adds to the previous commit by... - adding a test for the fully qualified dead/retry letter topics - de-duplicate the logic for the retry and dead letter topic Signed-off-by: onobc <[email protected]>
Collaborator
Author
|
Verified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.